Add HCL Support #438
Merged
Add HCL Support #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for HCL/Terraform: - ASCII art generated from `image_to_ascii.py` and the Terraform [logo](https://www.terraform.io/assets/images/og-image-8b3e4f7d.png). - `TrueColor` values derived from the RGB values therein.
|
As per the contribution guidelines, specifically that the ASCII logo's "dimensions must fall below 25*40", the logo is 25x40 but the addition of |
|
It shouldn't be a concern. It's the rendered width/height that we're trying to enforce. As long as the rendered characters stay within the dimensions, it should be OK 🙂 |
|
Thanks a lot for your contribution @PsypherPunk, in d591e1b I cleaned the ASCII art to make it more symmetrical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for HCL/Terraform:
image_to_ascii.pyand the Terraformlogo.
TrueColorvalues derived from the RGB values therein.